Testing and approving PR for the pyRevit repo

I wrote (with some AI help because it was late) a quick test here: Enhancement ex import by Wurschdhaud · Pull Request #3022 · pyrevitlabs/pyRevit · GitHub for a rather sweet and simple PR (thanks @pyrevti again!)
If you never did it, this is your chance to get acquainted with the wonderful world of PR review and testing :rainbow:
Jump in, don’t ask for permission and feel free to ask questions (not in the PR, but here, it will touch more people) _ you cannot break anything, so don’t be shy

2 Likes

Thanks Jean-Marc and all pyRevit giga chads.

Do you have a specific number Revit sessions to test before approving a PR?

Not sure I understand the question

In that sample PR you listed out 5 tests to perform. Do testers have to perform those 5 tests on X number of Revit models before you confidently merge with develop branch? Is there an X number of models you typically go with?

This is an hypothetical question, this has been merged after quick tests and reading the bits of code.

The number of models is not important
We are after: maintaining oof improving actual behaviour, make sure new functionality works, findings edge cases.

If a model (with an actual building with all elements of all categories) has all schedule types, with all parameters, you can try exporting all the schedule types, see if they all export, if all fields are accounted for. Make modifications in each excel. Use the import tools… …