Cloning pyRevit and our extensions for deployment with Powershell doesn't work

Thomas · August 9, 2022, 1:21pm

I think the seed error starts here:

eirannejad/pyRevit/blob/25eaabddbed4cbbaaca0965079e6bd993a9dffef/dev/pyRevitLabs/pyRevitLabs.PyRevit/PyRevitConfigs.cs#L79


      
                  try
                  {
                      File.Delete(PyRevitConsts.ConfigFilePath);
                  }
                  catch (Exception ex)
                  {
                      throw new PyRevitException(string.Format("Failed deleting config file \"{0}\" | {1}", PyRevitConsts.ConfigFilePath, ex.Message));
                  }
          }
          
          // copy config file into all users directory as seed config file
          public static void SeedConfig(bool lockSeedConfig = false)
          {
              string sourceFile = PyRevitConsts.ConfigFilePath;
              string targetFile = PyRevitConsts.AdminConfigFilePath;
          
              logger.Debug("Seeding config file \"{0}\" to \"{1}\"", sourceFile, targetFile);
          
              try
              {
                  if (File.Exists(sourceFile))

edit2:

… and the ConfigFilePath and AdminConfigFilePath will be the same…

github.com

eirannejad/pyRevit/blob/528940e1a3593f1ae5bd9bfd964d2f37fb9d45e1/dev/pyRevitLabs/pyRevitLabs.PyRevit/PyRevitConsts.cs#L199


      
          }
          
          // STANDARD PATHS ============================================================================================
          // pyRevit default extensions path
          // @reviewed
          public static string DefaultExtensionsPath =>
              Path.Combine(PyRevitLabsConsts.PyRevitPath, PyRevitConsts.ExtensionsDefaultDirName);
          
          // pyRevit config file path
          // @reviewed
          public static string ConfigFilePath {
              get {
                  string configRoot = UserEnv.IsRunAsElevated() ? PyRevitLabsConsts.PyRevitProgramDataPath : PyRevitLabsConsts.PyRevitPath;
                  var cfgFile = FindConfigFileInDirectory(configRoot);
                  return cfgFile != null ? cfgFile : Path.Combine(configRoot, DefaultConfigsFileName);
              }
          }
          
          // pyRevit config file path
          // @reviewed
          public static string AdminConfigFilePath {

…if IsRunAsElevated() gets true (if you run the ps script as admin):

github.com

eirannejad/pyRevit/blob/528940e1a3593f1ae5bd9bfd964d2f37fb9d45e1/dev/pyRevitLabs/pyRevitLabs.Common/UserEnv.cs#L100


      
                  foreach (ManagementObject oReturn in oReturnCollection) {
                      return oReturn["UserName"].ToString();
                  }
              }
              catch (Exception ex) {
                  logger.Debug("Failed to get logged in username. | {0}", ex.Message);
              }
              return null;
          }
          
          public static bool IsRunAsElevated() {
              WindowsIdentity id = WindowsIdentity.GetCurrent();
              return id.Owner != id.User;
          }
          
          public static bool IsRunAsAdmin() {
              WindowsIdentity id = WindowsIdentity.GetCurrent();
              WindowsPrincipal principal = new WindowsPrincipal(id);
              return principal.IsInRole(WindowsBuiltInRole.Administrator);
          }

The constants are defined here:

github.com

eirannejad/pyRevit/blob/7eb0a4e1f6d2509735b2da80168b1c8b0e5b2f20/dev/pyRevitLabs/pyRevitLabs.Common/Consts.cs#L48


      
          public const string OriginalRepoName = ProductName;
          public static string OriginalRepoId = string.Format(@"eirannejad/{0}", ProductName);
          public static string OriginalRepoBasePath = string.Format(@"https://github.com/{0}", OriginalRepoId);
          public static string OriginalRepoGitPath = OriginalRepoBasePath + DefaultGitDirName;
          
          // consts for recording pyrevit.exe config in the pyRevit configuration file
          public const string AppdataDirName = ProductName;
          public const string AppdataCacheDirName = "Cache";
          public const string AppdataLogsDirName = "Logs";
          
          // pyRevit %appdata% path
          // @reviewed
          public static string PyRevitPath => Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData), AppdataDirName);
          
          // pyRevit %programdata% path
          // @reviewed
          public static string PyRevitProgramDataPath => Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.CommonApplicationData), AppdataDirName);
          
          // pyrevit general cache folder 
          public static string CacheDirectory => Path.Combine(PyRevitPath, AppdataCacheDirName);

But I think it makes no sense that it copy from and to the same place!? I think there should be a temporary place, where the pyRevitConfig.ini gets prepared and finally it should copied to the programdata or appdata path.

Does it make a difference if I run the powershell as local or global admin?

/edit1:
I will try to use now the command “config” to configure pyRevit on my machine from an existing template configuration file:
pyrevit config <template_config_path> [–log=<log_file>]
$ pyrevit config “C:\myPyRevitTemplateConfig.ini”

Source:

Or maybe with another Powershell script snippet, I think it is the same result.

/edit3:
After inspecting the code, the documentation of pyrevit config is missing the --from= flag
The command only works if you use

pyrevit config --from=“X:<template_config_path>\pyReivt_config.ini”

and then it will be copied to the users %APPDATA%\pyRevit\pyRevit_config.ini.
Not sure yet if this solves my task or if I need to run a powershell script to copy the config template to each user.